Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up common code in examples #1871

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

felrock
Copy link
Collaborator

@felrock felrock commented Feb 16, 2024

move some utility functions into common.h

move some utility functions into common.h
@ggerganov ggerganov merged commit 07d0428 into ggerganov:master Feb 19, 2024
41 checks passed
Theldus added a commit to Theldus/whisper.cpp that referenced this pull request Feb 22, 2024
In commit dda4b0e of PR ggerganov#1872, I've introduced a check for the
existence of files before loading the model. However, I haven't
considered the case where whisper.cpp might read from stdin as well,
and in such cases, the checks should ignore the "-" argument as it
does not represent a regular file.

Additionally, this commit removes the usage of 'stat()' in favor of
the recently introduced function 'is_file_exist()' in common.cpp from
PR ggerganov#1871.

Apologies for the bug introduced in the previous PR and any
inconvenience it may have caused.
ggerganov pushed a commit that referenced this pull request Feb 22, 2024
In commit dda4b0e of PR #1872, I've introduced a check for the
existence of files before loading the model. However, I haven't
considered the case where whisper.cpp might read from stdin as well,
and in such cases, the checks should ignore the "-" argument as it
does not represent a regular file.

Additionally, this commit removes the usage of 'stat()' in favor of
the recently introduced function 'is_file_exist()' in common.cpp from
PR #1871.

Apologies for the bug introduced in the previous PR and any
inconvenience it may have caused.
jiahansu pushed a commit to WiseSync/whisper.cpp that referenced this pull request Apr 17, 2024
move some utility functions into common.h
jiahansu pushed a commit to WiseSync/whisper.cpp that referenced this pull request Apr 17, 2024
In commit dda4b0e of PR ggerganov#1872, I've introduced a check for the
existence of files before loading the model. However, I haven't
considered the case where whisper.cpp might read from stdin as well,
and in such cases, the checks should ignore the "-" argument as it
does not represent a regular file.

Additionally, this commit removes the usage of 'stat()' in favor of
the recently introduced function 'is_file_exist()' in common.cpp from
PR ggerganov#1871.

Apologies for the bug introduced in the previous PR and any
inconvenience it may have caused.
viktor-silakov pushed a commit to viktor-silakov/whisper_node_mic.cpp that referenced this pull request May 11, 2024
move some utility functions into common.h
viktor-silakov pushed a commit to viktor-silakov/whisper_node_mic.cpp that referenced this pull request May 11, 2024
In commit dda4b0e of PR ggerganov#1872, I've introduced a check for the
existence of files before loading the model. However, I haven't
considered the case where whisper.cpp might read from stdin as well,
and in such cases, the checks should ignore the "-" argument as it
does not represent a regular file.

Additionally, this commit removes the usage of 'stat()' in favor of
the recently introduced function 'is_file_exist()' in common.cpp from
PR ggerganov#1871.

Apologies for the bug introduced in the previous PR and any
inconvenience it may have caused.
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
move some utility functions into common.h
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
In commit dda4b0e of PR ggerganov#1872, I've introduced a check for the
existence of files before loading the model. However, I haven't
considered the case where whisper.cpp might read from stdin as well,
and in such cases, the checks should ignore the "-" argument as it
does not represent a regular file.

Additionally, this commit removes the usage of 'stat()' in favor of
the recently introduced function 'is_file_exist()' in common.cpp from
PR ggerganov#1871.

Apologies for the bug introduced in the previous PR and any
inconvenience it may have caused.
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
move some utility functions into common.h
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
In commit dda4b0e of PR ggerganov#1872, I've introduced a check for the
existence of files before loading the model. However, I haven't
considered the case where whisper.cpp might read from stdin as well,
and in such cases, the checks should ignore the "-" argument as it
does not represent a regular file.

Additionally, this commit removes the usage of 'stat()' in favor of
the recently introduced function 'is_file_exist()' in common.cpp from
PR ggerganov#1871.

Apologies for the bug introduced in the previous PR and any
inconvenience it may have caused.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants